tracing: Avoid memory leak in predicate_parse()
authorTomas Bortoli <tomasbortoli@gmail.com>
Tue, 28 May 2019 15:43:38 +0000 (17:43 +0200)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 28 May 2019 20:27:58 +0000 (16:27 -0400)
commitdfb4a6f2191a80c8b790117d0ff592fd712d3296
treeee5899455d1b43d2736e59c88e355ec4f1c08172
parent0c97bf863efce63d6ab7971dad811601e6171d2f
tracing: Avoid memory leak in predicate_parse()

In case of errors, predicate_parse() goes to the out_free label
to free memory and to return an error code.

However, predicate_parse() does not free the predicates of the
temporary prog_stack array, thence leaking them.

Link: http://lkml.kernel.org/r/20190528154338.29976-1-tomasbortoli@gmail.com
Cc: stable@vger.kernel.org
Fixes: 80765597bc587 ("tracing: Rewrite filter logic to be simpler and faster")
Reported-by: syzbot+6b8e0fb820e570c59e19@syzkaller.appspotmail.com
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
[ Added protection around freeing prog_stack[i].pred ]
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_filter.c