sched/fair: Fix wrong cpu selecting from isolated domain
authorXunlei Pang <xlpang@linux.alibaba.com>
Thu, 24 Sep 2020 06:48:47 +0000 (14:48 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 25 Sep 2020 12:23:25 +0000 (14:23 +0200)
commitdf3cb4ea1fb63ff326488efd671ba3c39034255e
tree102ed42c4886244edf2dd701d243762b851683f2
parent51bd5121c4eb25b911f6bc1ab4de5fe865fe0dcb
sched/fair: Fix wrong cpu selecting from isolated domain

We've met problems that occasionally tasks with full cpumask
(e.g. by putting it into a cpuset or setting to full affinity)
were migrated to our isolated cpus in production environment.

After some analysis, we found that it is due to the current
select_idle_smt() not considering the sched_domain mask.

Steps to reproduce on my 31-CPU hyperthreads machine:
1. with boot parameter: "isolcpus=domain,2-31"
   (thread lists: 0,16 and 1,17)
2. cgcreate -g cpu:test; cgexec -g cpu:test "test_threads"
3. some threads will be migrated to the isolated cpu16~17.

Fix it by checking the valid domain mask in select_idle_smt().

Fixes: 10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings())
Reported-by: Wetp Zhang <wetp.zy@linux.alibaba.com>
Signed-off-by: Xunlei Pang <xlpang@linux.alibaba.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Jiang Biao <benbjiang@tencent.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/1600930127-76857-1-git-send-email-xlpang@linux.alibaba.com
kernel/sched/fair.c