ceph: clean up locking annotation for ceph_get_snap_realm and __lookup_snap_realm
authorJeff Layton <jlayton@kernel.org>
Tue, 1 Jun 2021 13:24:38 +0000 (09:24 -0400)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 28 Jun 2021 22:15:51 +0000 (00:15 +0200)
commitdf2c0cb7f8e8c83e495260ad86df8c5da947f2a7
tree62b4b4adf42ce47b272c0f108724b690cd312363
parenta6862e6708c15995bc10614b2ef34ca35b4b9078
ceph: clean up locking annotation for ceph_get_snap_realm and __lookup_snap_realm

They both say that the snap_rwsem must be held for write, but I don't
see any real reason for it, and it's not currently always called that
way.

The lookup is just walking the rbtree, so holding it for read should be
fine there. The "get" is bumping the refcount and (possibly) removing
it from the empty list. I see no need to hold the snap_rwsem for write
for that.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/snap.c