projects / linux-2.6-microblaze.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3765252) | patch
sky2: Avoid race in sky2_change_mtu
authorMike McCormack <mikem@ring3k.org>
Thu, 13 May 2010 06:12:49 +0000 (06:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 May 2010 10:06:20 +0000 (03:06 -0700)
commitdf01093bb08916f434ebedde4610805d4105d05f
tree85f19aa28e7b525ac22c5a981d2f4f83de97858atree
parent37652522faa0877dc6d0dbb6b999bdccc07f0e89commit | diff
sky2: Avoid race in sky2_change_mtu

netif_stop_queue does not ensure all in-progress transmits are complete,
 so use netif_tx_disable() instead.

Secondly, make sure NAPI polls are disabled before stopping the tx queue,
 otherwise sky2_status_intr might trigger a TX queue wakeup between when
 we stop the queue and NAPI is disabled.

Signed-off-by: Mike McCormack <mikem@ring3k.org>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sky2.c diff | blob | history
MicroBlaze GIT Repository