ASoC: topology: avoid uninitialized kcontrol_type
authorArnd Bergmann <arnd@arndb.de>
Fri, 9 Dec 2016 11:51:46 +0000 (12:51 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 12 Dec 2016 15:43:02 +0000 (15:43 +0000)
commitdd5abb742071a962be4403f171063ed1e9d4202d
tree12b70438a3e590c9bcdb2a1618f351cfdb9acf8d
parenteea3dd4f1247aa8654194fb19ade22c94c42e41a
ASoC: topology: avoid uninitialized kcontrol_type

When num_kcontrols is zero, widget->dobj.widget.kcontrol_type
gets set to an uninitialized local variable:

sound/soc/soc-topology.c: In function 'soc_tplg_dapm_widget_create':
sound/soc/soc-topology.c:1566:36: error: 'kcontrol_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I could not figure out which of the valid types would be appropriate
here, so this sets it to '0', which is invalid but at least well-defined
here. There is probably a better way to address the issue.

Fixes: eea3dd4f1247 ("ASoC: topology: Only free TLV for volume mixers of a widget")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c