drm/v3d: Fix missing error code in v3d_submit_cpu_ioctl()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Mon, 4 Dec 2023 12:21:01 +0000 (04:21 -0800)
committerMelissa Wen <melissa.srw@gmail.com>
Mon, 4 Dec 2023 22:30:33 +0000 (21:30 -0100)
commitdce94061f0d02f5ab355390a6e63d3dbea938b72
treed6e0b1cb156fe6f8a7d827dec9b56220fb262463
parent90422201f8f2b4e26ab7bd43b92786a11c1ffebf
drm/v3d: Fix missing error code in v3d_submit_cpu_ioctl()

Smatch warns:
drivers/gpu/drm/v3d/v3d_submit.c:1222 v3d_submit_cpu_ioctl()
warn: missing error code 'ret'

When there is no job type or job is submitted with wrong number of BOs
it is an error path, ret is zero at this point which is incorrect
return.

Fix this by changing it to -EINVAL.

Fixes: aafc1a2bea67 ("drm/v3d: Add a CPU job submission")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231204122102.181298-1-harshit.m.mogalapalli@oracle.com
drivers/gpu/drm/v3d/v3d_submit.c