NFS: Avoid flushing data while holding directory locks in nfs_rename()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 27 Apr 2025 22:21:06 +0000 (18:21 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 16 May 2025 20:31:35 +0000 (22:31 +0200)
commitdcd21b609d4abc7303f8683bce4f35d78d7d6830
tree1399703e057ba5f39c62bc0fbccccb407e3c536b
parent28511504f3ac73ebf45cbbe0dafeca1026e9a8f3
NFS: Avoid flushing data while holding directory locks in nfs_rename()

The Linux client assumes that all filehandles are non-volatile for
renames within the same directory (otherwise sillyrename cannot work).
However, the existence of the Linux 'subtree_check' export option has
meant that nfs_rename() has always assumed it needs to flush writes
before attempting to rename.

Since NFSv4 does allow the client to query whether or not the server
exhibits this behaviour, and since knfsd does actually set the
appropriate flag when 'subtree_check' is enabled on an export, it
should be OK to optimise away the write flushing behaviour in the cases
where it is clearly not needed.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
fs/nfs/client.c
fs/nfs/dir.c
include/linux/nfs_fs_sb.h