dmaengine: tegra-apb: Error out if DMA_PREP_INTERRUPT flag is unset
authorDmitry Osipenko <digetx@gmail.com>
Wed, 29 May 2019 21:43:55 +0000 (00:43 +0300)
committerVinod Koul <vkoul@kernel.org>
Tue, 4 Jun 2019 12:15:47 +0000 (17:45 +0530)
commitdc161064beb83c668e0f85766b92b1e7ed186e58
tree645d5816df6ad2fbcc9a51696a8f894e011a609d
parentc983d805a7bb253b9015bc2c03bc8827031ce590
dmaengine: tegra-apb: Error out if DMA_PREP_INTERRUPT flag is unset

Apparently driver was never tested with DMA_PREP_INTERRUPT flag being
unset since it completely disables interrupt handling instead of skipping
the callbacks invocations, hence putting channel into unusable state.

The flag is always set by all of kernel drivers that use APB DMA, so let's
error out in otherwise case for consistency. It won't be difficult to
support that case properly if ever will be needed.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/tegra20-apb-dma.c