watchdog: Start watchdog in watchdog_set_last_hw_keepalive only if appropriate
authorJan Kiszka <jan.kiszka@siemens.com>
Sun, 1 Aug 2021 07:56:25 +0000 (09:56 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 22 Aug 2021 08:28:12 +0000 (10:28 +0200)
commitdbe80cf471f940db3063197b7adb1169f89be9ed
treebc2ba2cc5a2addc328106ceab06ef7a9387645fa
parent585ba602b1ff76dd6e7fbd488a8c5921ae422305
watchdog: Start watchdog in watchdog_set_last_hw_keepalive only if appropriate

We must not pet a running watchdog when handle_boot_enabled is off
because this will kick off automatic triggering before userland is
running, defeating the purpose of the handle_boot_enabled control.
Furthermore, don't ping in case watchdog_set_last_hw_keepalive was
called incorrectly when the hardware watchdog is actually not running.

Fixed: cef9572e9af3 ("watchdog: add support for adjusting last known HW keepalive time")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/93d56386-6e37-060b-55ce-84de8cde535f@web.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/watchdog_dev.c