netfs: Fix undifferentiation of DIO reads from unbuffered reads
authorDavid Howells <dhowells@redhat.com>
Fri, 23 May 2025 07:57:52 +0000 (08:57 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 23 May 2025 08:35:03 +0000 (10:35 +0200)
commitdb26d62d79e4068934ad0dccdb92715df36352b9
tree322b7ce500512ffaf7dff5689006bbf9ccf060e7
parent5fddfbc0cbc55a6b506f8cd07c58a152a3b535d6
netfs: Fix undifferentiation of DIO reads from unbuffered reads

On cifs, "DIO reads" (specified by O_DIRECT) need to be differentiated from
"unbuffered reads" (specified by cache=none in the mount parameters).  The
difference is flagged in the protocol and the server may behave
differently: Windows Server will, for example, mandate that DIO reads are
block aligned.

Fix this by adding a NETFS_UNBUFFERED_READ to differentiate this from
NETFS_DIO_READ, parallelling the write differentiation that already exists.
cifs will then do the right thing.

Fixes: 016dc8516aec ("netfs: Implement unbuffered/DIO read support")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/3444961.1747987072@warthog.procyon.org.uk
Reviewed-by: "Paulo Alcantara (Red Hat)" <pc@manguebit.com>
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
cc: Steve French <sfrench@samba.org>
cc: netfs@lists.linux.dev
cc: v9fs@lists.linux.dev
cc: linux-afs@lists.infradead.org
cc: linux-cifs@vger.kernel.org
cc: ceph-devel@vger.kernel.org
cc: linux-nfs@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
12 files changed:
fs/9p/vfs_addr.c
fs/afs/write.c
fs/ceph/addr.c
fs/netfs/direct_read.c
fs/netfs/main.c
fs/netfs/misc.c
fs/netfs/objects.c
fs/netfs/read_collect.c
fs/nfs/fscache.c
fs/smb/client/file.c
include/linux/netfs.h
include/trace/events/netfs.h