ALSA: usb-audio: Fix an OOB bug in parse_audio_mixer_unit
authorHui Peng <benquike@gmail.com>
Wed, 14 Aug 2019 02:34:04 +0000 (22:34 -0400)
committerTakashi Iwai <tiwai@suse.de>
Wed, 14 Aug 2019 18:05:56 +0000 (20:05 +0200)
commitdaac07156b330b18eb5071aec4b3ddca1c377f2c
treecca841f4517aff5cca1d5edbb49b947cdcf9a780
parent871b9066027702e6e6589da0e1edd3b7dede7205
ALSA: usb-audio: Fix an OOB bug in parse_audio_mixer_unit

The `uac_mixer_unit_descriptor` shown as below is read from the
device side. In `parse_audio_mixer_unit`, `baSourceID` field is
accessed from index 0 to `bNrInPins` - 1, the current implementation
assumes that descriptor is always valid (the length  of descriptor
is no shorter than 5 + `bNrInPins`). If a descriptor read from
the device side is invalid, it may trigger out-of-bound memory
access.

```
struct uac_mixer_unit_descriptor {
__u8 bLength;
__u8 bDescriptorType;
__u8 bDescriptorSubtype;
__u8 bUnitID;
__u8 bNrInPins;
__u8 baSourceID[];
}
```

This patch fixes the bug by add a sanity check on the length of
the descriptor.

Reported-by: Hui Peng <benquike@gmail.com>
Reported-by: Mathias Payer <mathias.payer@nebelwelt.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Peng <benquike@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c