nvmet: move the call to nvmet_ns_changed out of nvmet_ns_revalidate
authorChristoph Hellwig <hch@lst.de>
Tue, 15 Mar 2022 07:13:04 +0000 (08:13 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Mar 2022 09:36:47 +0000 (10:36 +0100)
commitda7837339641601f202f27515771dc0646083938
tree724f0875ea43932bccf4af57eecdaeec50bd6e8d
parent98152eb70fffad910ee7c511b110afe98f162fc5
nvmet: move the call to nvmet_ns_changed out of nvmet_ns_revalidate

nvmet_ns_changed states via lockdep that the ns->subsys->lock must be
held. The only caller of nvmet_ns_changed which does not acquire that
lock is nvmet_ns_revalidate. nvmet_ns_revalidate has 3 callers,
of which 2 do not acquire that lock: nvmet_execute_identify_cns_cs_ns
and nvmet_execute_identify_ns. The other caller
nvmet_ns_revalidate_size_store does acquire the lock.

Move the call to nvmet_ns_changed from nvmet_ns_revalidate to the callers
so that they can perform the correct locking as needed.

This issue was found using a static type-based analyser and manually
verified.

Reported-by: Niels Dossche <dossche.niels@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
drivers/nvme/target/admin-cmd.c
drivers/nvme/target/configfs.c
drivers/nvme/target/core.c
drivers/nvme/target/nvmet.h
drivers/nvme/target/zns.c