drm/i915: Properly clear crtc state when disabling it fully, again
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 17 Feb 2022 10:32:21 +0000 (12:32 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 23 Feb 2022 11:29:33 +0000 (13:29 +0200)
commitd95c25668f2379c807e1fa6328954f494c4e2454
tree3afcead399415840e07610a4a4f3a96692474687
parent7d7007686b0f999f90690d27eb013aba2eb8dc30
drm/i915: Properly clear crtc state when disabling it fully, again

Currently we just leave the old gunk lying around in the crtc
state when userspace asks us to fully disable the crtc. That
doesn't match what the state would be had we never even enabled
the crtc in the first place. So let's make this consistent and
call intel_crtc_prepare_cleared_state() for disabled crtcs as well
(excluding bigjoiner slaves of course which have had their state
copied from the master).

I actually already did this once in commit fff13e63a141 ("drm/i915:
Clear most of crtc state when disabling the crtc") but then
commit 19f65a3dbf75 ("drm/i915: Try to make bigjoiner work in atomic
check") undid it all :(

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220217103221.10405-5-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/display/intel_display.c