xfrm: iptfs: only publish mode_data after clone setup
authorPaul Moses <p@1g4.org>
Mon, 16 Mar 2026 14:56:51 +0000 (14:56 +0000)
committerSteffen Klassert <steffen.klassert@secunet.com>
Tue, 17 Mar 2026 10:43:14 +0000 (11:43 +0100)
commitd849a2f7309fc0616e79d13b008b0a47e0458b6e
treef11cb03bf80c6a11b7cb6f0a1c9d46ede74bf5d1
parenteb2d16a7d599dc9d4df391b5e660df9949963786
xfrm: iptfs: only publish mode_data after clone setup

iptfs_clone_state() stores x->mode_data before allocating the reorder
window. If that allocation fails, the code frees the cloned state and
returns -ENOMEM, leaving x->mode_data pointing at freed memory.

The xfrm clone unwind later runs destroy_state() through x->mode_data,
so the failed clone path tears down IPTFS state that clone_state()
already freed.

Keep the cloned IPTFS state private until all allocations succeed so
failed clones leave x->mode_data unset. The destroy path already
handles a NULL mode_data pointer.

Fixes: 6be02e3e4f37 ("xfrm: iptfs: handle reordering of received packets")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Moses <p@1g4.org>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_iptfs.c