fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()
authorTobias Klauser <tklauser@distanz.ch>
Mon, 24 Apr 2017 21:34:20 +0000 (16:34 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Apr 2017 09:38:56 +0000 (11:38 +0200)
commitd721f9bbe6a7d9543f560053f8be5237e7db18e9
treeef87e8fa5e5887027e1225eb832e2d7a1b186f7e
parent139752a210544dd02bac5c21322751de300ece93
fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in
alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also,
in the error path for _alt_hps2fpga_enable_set() a call to
fpga_bridge_unregister() is made even though the bridge was not
registered yet.

Remove the unnecessary call to fpga_bridge_unregister() and call
clk_disable_unprepare() in both error paths in order to make sure the
clock gets properly disabled and unprepared.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/altera-hps2fpga.c