efi: Fix error handling in add_sysfs_runtime_map_entry()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Apr 2015 13:46:28 +0000 (16:46 +0300)
committerMatt Fleming <matt.fleming@intel.com>
Tue, 5 May 2015 15:20:13 +0000 (16:20 +0100)
commitd67e199611b986b345ea3087ee2e4a15da1c98b3
tree8b405a9337c27c2ae7b64080a88806f88d8c7363
parent98b228f55014870092c15d7d168fecac69f2f12a
efi: Fix error handling in add_sysfs_runtime_map_entry()

I spotted two (difficult to hit) bugs while reviewing this.

1)  There is a double free bug because we unregister "map_kset" in
    add_sysfs_runtime_map_entry() and also efi_runtime_map_init().
2)  If we fail to allocate "entry" then we should return
    ERR_PTR(-ENOMEM) instead of NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Guangyu Sun <guangyu.sun@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
drivers/firmware/efi/runtime-map.c