PCI: vmd: Set devices to D0 before enabling PM L1 Substates
authorJian-Hong Pan <jhp@endlessos.org>
Tue, 1 Oct 2024 08:34:38 +0000 (16:34 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 6 Nov 2024 22:32:26 +0000 (16:32 -0600)
commitd66041063192497a4a97d21dbf86b79a03a7f4fb
tree3d47b1a5dc4d1848ab5cd1e9d38d2e3cfed55a5c
parente1714f3b1f4d2af5df26e4a0e4a70ef64b15e3ee
PCI: vmd: Set devices to D0 before enabling PM L1 Substates

The remapped PCIe Root Port and the child device have PM L1 Substates
capability, but they are disabled originally.

Here is a failed example on ASUS B1400CEAE:

  Capabilities: [900 v1] L1 PM Substates
        L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1- ASPM_L1.2+ ASPM_L1.1- L1_PM_Substates+
                  PortCommonModeRestoreTime=32us PortTPowerOnTime=10us
        L1SubCtl1: PCI-PM_L1.2- PCI-PM_L1.1- ASPM_L1.2+ ASPM_L1.1-
                   T_CommonMode=0us LTR1.2_Threshold=101376ns
        L1SubCtl2: T_PwrOn=50us

Enable PCI-PM L1 PM Substates for devices below VMD while they are in D0
(see PCIe r6.0, sec 5.5.4).

Link: https://lore.kernel.org/r/20241001083438.10070-4-jhp@endlessos.org
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218394
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
drivers/pci/controller/vmd.c