btrfs: mark ordered extent and inode with error if we fail to finish
authorJosef Bacik <josef@toxicpanda.com>
Wed, 19 May 2021 13:38:27 +0000 (09:38 -0400)
committerDavid Sterba <dsterba@suse.com>
Thu, 27 May 2021 21:31:01 +0000 (23:31 +0200)
commitd61bec08b904cf171835db98168f82bc338e92e4
tree7b2975c52c3460fbed7cc53ba5b30c40db40a10d
parent856bd270dc4db209c779ce1e9555c7641ffbc88e
btrfs: mark ordered extent and inode with error if we fail to finish

While doing error injection testing I saw that sometimes we'd get an
abort that wouldn't stop the current transaction commit from completing.
This abort was coming from finish ordered IO, but at this point in the
transaction commit we should have gotten an error and stopped.

It turns out the abort came from finish ordered io while trying to write
out the free space cache.  It occurred to me that any failure inside of
finish_ordered_io isn't actually raised to the person doing the writing,
so we could have any number of failures in this path and think the
ordered extent completed successfully and the inode was fine.

Fix this by marking the ordered extent with BTRFS_ORDERED_IOERR, and
marking the mapping of the inode with mapping_set_error, so any callers
that simply call fdatawait will also get the error.

With this we're seeing the IO error on the free space inode when we fail
to do the finish_ordered_io.

CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c