media: vivid: fix incorrect assignment operation when setting video mode
authorColin Ian King <colin.king@canonical.com>
Tue, 4 Jun 2019 14:55:15 +0000 (10:55 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 5 Jun 2019 19:25:15 +0000 (15:25 -0400)
commitd4ec9550e4b2d2e357a46fdc65d8ef3d4d15984c
tree4e44e10c4ad7eeb919c70146065565587390eb6a
parent0c6280b3c353868a1a40596585db43af756b0617
media: vivid: fix incorrect assignment operation when setting video mode

The assigment of FB_VMODE_NONINTERLACE to var->vmode should be a
bit-wise or of FB_VMODE_NONINTERLACE instead of an assignment,
otherwise the previous clearing of the FB_VMODE_MASK bits of
var->vmode makes no sense and is redundant.

Addresses-Coverity: ("Unused value")
Fixes: ad4e02d5081d ("[media] vivid: add a simple framebuffer device for overlay testing")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vivid/vivid-osd.c