iio: adc: ina2xx: add in early -EINVAL returns in case statements
authorColin Ian King <colin.king@canonical.com>
Tue, 16 Oct 2018 16:14:18 +0000 (17:14 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 21 Oct 2018 14:43:11 +0000 (15:43 +0100)
commitd42282db6c41cd1896090c3bc95fc9cfd7268189
tree91df9df6da2666fa0c580218f337b9149b6c1c45
parente480490c90956f8e46ba666b49bc56000083bbfe
iio: adc: ina2xx: add in early -EINVAL returns in case statements

Static analysis with CoverityScan is throwing warnings that specific
case statements are missing breaks.  Rather than adding breaks, add
return -EINVAL to the specific case statements to clarify the
error return paths. Fix also saves 50 bytes.

Before:
   text    data     bss     dec     hex filename
  21418    4936     128   26482    6772 drivers/iio/adc/ina2xx-adc.o

After:
  dec     hex filename
  21370    4936     128   26434    6742 drivers/iio/adc/ina2xx-adc.o

(gcc 8.2, x86-64)

Detected by CoverityScan, CID#1462408 ("Missing break in switch")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Stefan BrĂ¼ns <stefan.bruens@rwth-aachen.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ina2xx-adc.c