ALSA: hda/analog - Sink ad198x_shutup() and shuffle CONFIG_PM guards
authorNathan Chancellor <nathan@kernel.org>
Wed, 18 Aug 2021 01:27:05 +0000 (18:27 -0700)
committerTakashi Iwai <tiwai@suse.de>
Wed, 18 Aug 2021 05:51:09 +0000 (07:51 +0200)
commitd2d837563743590cbf07bf786941e73a8c40b031
treea058a27ef3870784a0e3b6bfc7153b3cf7b070fc
parentf8b32a6daf35f54f6260df7446e4069af64f0fcc
ALSA: hda/analog - Sink ad198x_shutup() and shuffle CONFIG_PM guards

When CONFIG_PM is not set, there is an unused function warning:

sound/pci/hda/patch_analog.c:115:13: warning: unused function
'ad198x_shutup' [-Wunused-function]
static void ad198x_shutup(struct hda_codec *codec)
            ^
1 warning generated.

Sink ad198x_shutup() into ad198x_suspend(), as it is only called in that
one space. Move the CONFIG_PM guards above ad198x_power_eapd_write() as
it is only called in ad198x_power_eapd(), which is in turn only called
in ad198x_power_eapd(). Those two functions are large enough that they
are left alone.

Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210818012705.311963-2-nathan@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_analog.c