NFSD: Fix a null reference case in find_or_create_lock_stateid()
authorKinglong Mee <kinglongmee@gmail.com>
Wed, 18 Jan 2017 11:04:42 +0000 (19:04 +0800)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 31 Jan 2017 17:29:24 +0000 (12:29 -0500)
commitd19fb70dd68c4e960e2ac09b0b9c79dfdeefa726
tree8ce91162810ddf366f475ca22861c705aea115fa
parent566cf877a1fcb6d6dc0126b076aad062054c2637
NFSD: Fix a null reference case in find_or_create_lock_stateid()

nfsd assigns the nfs4_free_lock_stateid to .sc_free in init_lock_stateid().

If nfsd doesn't go through init_lock_stateid() and put stateid at end,
there is a NULL reference to .sc_free when calling nfs4_put_stid(ns).

This patch let the nfs4_stid.sc_free assignment to nfs4_alloc_stid().

Cc: stable@vger.kernel.org
Fixes: 356a95ece7aa "nfsd: clean up races in lock stateid searching..."
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4layouts.c
fs/nfsd/nfs4state.c
fs/nfsd/state.h