net: cleanup gfp mask in alloc_skb_with_frags
authorMichal Hocko <mhocko@suse.com>
Thu, 28 Jun 2018 15:53:06 +0000 (17:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jun 2018 11:18:49 +0000 (20:18 +0900)
commitd14b56f508ad70eca3e659545aab3c45200f258c
tree710920f42f63c6149ffa9a0bf28627d3f9babd0d
parent7009828914d362d99e138e4cfdfbf46507607456
net: cleanup gfp mask in alloc_skb_with_frags

alloc_skb_with_frags uses __GFP_NORETRY for non-sleeping allocations
which is just a noop and a little bit confusing.

__GFP_NORETRY was added by ed98df3361f0 ("net: use __GFP_NORETRY for
high order allocations") to prevent from the OOM killer. Yet this was
not enough because fb05e7a89f50 ("net: don't wait for order-3 page
allocation") didn't want an excessive reclaim for non-costly orders
so it made it completely NOWAIT while it preserved __GFP_NORETRY in
place which is now redundant.

Drop the pointless __GFP_NORETRY because this function is used as
copy&paste source for other places.

Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c