selftests/lkdtm: Disable CONFIG_UBSAN_TRAP in test config
authorRicardo Cañuelo <ricardo.canuelo@collabora.com>
Wed, 2 Aug 2023 06:32:52 +0000 (08:32 +0200)
committerKees Cook <keescook@chromium.org>
Thu, 28 Sep 2023 23:39:08 +0000 (16:39 -0700)
commitcf77bf698887c3b9ebed76dea492b07a3c2c7632
treefc3e327e44684fdcfd08120ebbf36fb307e80c73
parenteac80dd4bc22bb754a5476fe5064e662c22f51ba
selftests/lkdtm: Disable CONFIG_UBSAN_TRAP in test config

The lkdtm selftest config fragment enables CONFIG_UBSAN_TRAP to make the
ARRAY_BOUNDS test kill the calling process when an out-of-bound access
is detected by UBSAN. However, after this [1] commit, UBSAN is triggered
under many new scenarios that weren't detected before, such as in struct
definitions with fixed-size trailing arrays used as flexible arrays. As
a result, CONFIG_UBSAN_TRAP=y has become a very aggressive option to
enable except for specific situations.

`make kselftest-merge` applies CONFIG_UBSAN_TRAP=y to the kernel config
for all selftests, which makes many of them fail because of system hangs
during boot.

This change removes the config option from the lkdtm kselftest and
configures the ARRAY_BOUNDS test to look for UBSAN reports rather than
relying on the calling process being killed.

[1] commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC")'

Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230802063252.1917997-1-ricardo.canuelo@collabora.com
Signed-off-by: Kees Cook <keescook@chromium.org>
tools/testing/selftests/lkdtm/config
tools/testing/selftests/lkdtm/tests.txt