visorbus: fix error return code in visorchipset_init()
authorZhen Lei <thunder.leizhen@huawei.com>
Fri, 28 May 2021 08:26:14 +0000 (16:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Jun 2021 13:27:26 +0000 (15:27 +0200)
commitce52ec5beecc1079c251f60e3973b3758f60eb59
tree14ef3e9cfdc2296b3a6d2049eb856876f5bc188f
parentcc196fed0394aa03ec75e22274edb18c8b03ad00
visorbus: fix error return code in visorchipset_init()

Commit 1366a3db3dcf ("staging: unisys: visorbus: visorchipset_init clean
up gotos") assigns the initial value -ENODEV to the local variable 'err',
and the first several error branches will return this value after "goto
error". But commit f1f537c2e7f5 ("staging: unisys: visorbus: Consolidate
controlvm channel creation.") overwrites 'err' in the middle of the way.
As a result, some error branches do not successfully return the initial
value -ENODEV of 'err', but return 0.

In addition, when kzalloc() fails, -ENOMEM should be returned instead of
-ENODEV.

Fixes: f1f537c2e7f5 ("staging: unisys: visorbus: Consolidate controlvm channel creation.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210528082614.9337-1-thunder.leizhen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/visorbus/visorchipset.c