erofs: initialized fields can only be observed after bit is set
authorGao Xiang <hsiangkao@redhat.com>
Tue, 9 Feb 2021 13:06:18 +0000 (21:06 +0800)
committerGao Xiang <hsiangkao@redhat.com>
Thu, 11 Feb 2021 03:55:28 +0000 (11:55 +0800)
commitce063129181312f8781a047a50be439c5859747b
tree065c18d1f666853330c2a02cc1e0c4fa9a80c646
parentbde545295b710bdd13a0fcd4b9fddd2383eeeb3a
erofs: initialized fields can only be observed after bit is set

Currently, although set_bit() & test_bit() pairs are used as a fast-
path for initialized configurations. However, these atomic ops are
actually relaxed forms. Instead, load-acquire & store-release form is
needed to make sure uninitialized fields won't be observed in advance
here (yet no such corresponding bitops so use full barriers instead.)

Link: https://lore.kernel.org/r/20210209130618.15838-1-hsiangkao@aol.com
Fixes: 62dc45979f3f ("staging: erofs: fix race of initializing xattrs of a inode at the same time")
Fixes: 152a333a5895 ("staging: erofs: add compacted compression indexes support")
Cc: <stable@vger.kernel.org> # 5.3+
Reported-by: Huang Jianan <huangjianan@oppo.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
fs/erofs/xattr.c
fs/erofs/zmap.c