ipmi: Fix some error cleanup issues
authorCorey Minyard <cminyard@mvista.com>
Wed, 28 Feb 2018 14:09:49 +0000 (08:09 -0600)
committerCorey Minyard <cminyard@mvista.com>
Wed, 7 Mar 2018 01:47:17 +0000 (19:47 -0600)
commitcc095f0ac1f7c200e51a5c2a78a43c9f42049dbb
treecea28774af6227161791960af5b705b0999d9c88
parent243ac21035176ac9692c1308a9f3b8f6a4e5d733
ipmi: Fix some error cleanup issues

device_remove_group() was called on any cleanup, even if the
device attrs had not been added yet.  That can occur in certain
error scenarios, so add a flag to know if it has been added.

Also make sure we remove the dev if we added it ourselves.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org # 4.15
Cc: Laura Abbott <labbott@redhat.com>
Tested-by: Bill Perkins <wmp@grnwood.net>
drivers/char/ipmi/ipmi_si_intf.c