cxl/cdat: Free correct buffer on checksum error
authorIra Weiny <ira.weiny@intel.com>
Fri, 17 Nov 2023 00:03:29 +0000 (16:03 -0800)
committerDan Williams <dan.j.williams@intel.com>
Sat, 9 Dec 2023 00:14:28 +0000 (16:14 -0800)
commitc65efe3685f5d150eeca5599afeabdc85da899d1
tree40c85f66f4d34f5df5da9da39b87a0b630d851bd
parent6f5c4eca48ffe18307b4e1d375817691c9005c87
cxl/cdat: Free correct buffer on checksum error

The new 6.7-rc1 kernel now checks the checksum on CDAT data.  While
using a branch of Fan's DCD qemu work (and specifying DCD devices), the
following splat was observed.

WARNING: CPU: 1 PID: 1384 at drivers/base/devres.c:1064 devm_kfree+0x4f/0x60
...
RIP: 0010:devm_kfree+0x4f/0x60
...
  ? devm_kfree+0x4f/0x60
  read_cdat_data+0x1a0/0x2a0 [cxl_core]
  cxl_port_probe+0xdf/0x200 [cxl_port]
...

The issue in qemu is still unknown but the spat is a straight forward
bug in the CDAT checksum processing code.  Use a CDAT buffer variable to
ensure the devm_free() works correctly on error.

Fixes: 670e4e88f3b1 ("cxl: Add checksum verification to CDAT from CXL")
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
Link: http://lore.kernel.org/r/20231116-fix-cdat-devm-free-v1-1-b148b40707d7@intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/pci.c