net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 8 May 2023 14:26:29 +0000 (16:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 May 2023 02:57:01 +0000 (19:57 -0700)
commitc5f3ffe35cc92cce6292b5304409f3edc9281d66
tree3da5f89617fec025e468cab354687926e09f3999
parentb9bc44fe068d6e44504f6f3eb03a325fd6843d60
net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition

The remove callback is only ever called after .probe() returned
successfully. After that get_stmmac_bsp_priv() always return non-NULL.

Side note: The early exit would also be a bug because the return value
of qcom_ethqos_remove() is ignored by the device core and the device is
unbound unconditionally. So exiting early resulted in a dangerous
resource leak as all devm allocated resources (some memory and the
register mappings) are freed but the network device stays around.  Using
the network device afterwards probably oopses.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c