drm/i915: Accurately initialize fifo underrun state on gmch platforms
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 14 May 2014 13:40:34 +0000 (15:40 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 21 May 2014 09:32:06 +0000 (11:32 +0200)
commitc5ab3bc07e252a32b170ab4797142ef117c367a0
tree68f319a72d7279fc25af17546a2ba4b93107079f
parentfd68e2379ba56afda1db5bae4d1563f088bbc0c8
drm/i915: Accurately initialize fifo underrun state on gmch platforms

We don't have hardware based disable bits on gmch platforms, so need
to block spurious underrun reports in software. Which means that we
_must_ start out with fifo underrun reporting disabled everywhere.

This is in big contrast to ilk/hsw/cpt where there's only _one_
disable bit for all platforms and hence we must allow underrun
reporting on disabled pipes. Otherwise nothing really works,
especially the CRC support since that's key'ed off the same irq
disable bit.

This allows us to ditch the fifo underrun reporting hack from the vlv
runtime pm code and unexport the internal function from i915_irq.c
again. Yay!

v2: Keep the display irq disabling, spotted by Imre.

Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_drv.h
drivers/gpu/drm/i915/intel_pm.c