ASoC: sma1307: fix uninitialized variable refence
authorArnd Bergmann <arnd@arndb.de>
Wed, 13 Nov 2024 17:57:13 +0000 (18:57 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 14 Nov 2024 11:42:41 +0000 (11:42 +0000)
commitc48a4497356f701f94f1951626637ae240af909e
treef2d58d147ccda7e8c4f347d4c0d8374d37cad92a
parent07db6d5e12bbc2d698ca01113b0db62bc7b80e3f
ASoC: sma1307: fix uninitialized variable refence

When firmware loading is disabled, gcc warns that the local
'fw' variable fails to get initialized:

sound/soc/codecs/sma1307.c: In function 'sma1307_setting_loaded.isra':
sound/soc/codecs/sma1307.c:1717:12: error: 'fw' is used uninitialized [-Werror=uninitialized]
 1717 |         if (!fw) {
      |            ^
sound/soc/codecs/sma1307.c:1712:32: note: 'fw' was declared here
 1712 |         const struct firmware *fw;

Check the return code from request_firmware() to ensure that the
firmware is correctly set, and drop the incorrect release_firmware()
on that uninitialized data.

Fixes: 576c57e6b4c1 ("ASoC: sma1307: Add driver for Iron Device SMA1307")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20241113175734.2443315-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sma1307.c