ax25: fix a use-after-free in ax25_fillin_cb()
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 29 Dec 2018 21:56:36 +0000 (13:56 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 30 Dec 2018 22:07:54 +0000 (14:07 -0800)
commitc433570458e49bccea5c551df628d058b3526289
tree05427f71af7a74fb15b0eb08f138cc6004a225c1
parent7f334a7e1ae113212e39aafba51352ea9ab8c9f9
ax25: fix a use-after-free in ax25_fillin_cb()

There are multiple issues here:

1. After freeing dev->ax25_ptr, we need to set it to NULL otherwise
   we may use a dangling pointer.

2. There is a race between ax25_setsockopt() and device notifier as
   reported by syzbot. Close it by holding RTNL lock.

3. We need to test if dev->ax25_ptr is NULL before using it.

Reported-and-tested-by: syzbot+ae6bb869cbed29b29040@syzkaller.appspotmail.com
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ax25/af_ax25.c
net/ax25/ax25_dev.c