iomap: Allow filesystem to call iomap_dio_complete without i_rwsem
authorChristoph Hellwig <hch@lst.de>
Mon, 28 Sep 2020 15:51:08 +0000 (08:51 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 28 Sep 2020 15:51:08 +0000 (08:51 -0700)
commitc3d4ed1abecfcfc801199cfadb71f5b80e025d9e
treee9c9f9b12f6161b19673284bfa80719a115d8b59
parent4595a298d5563cf76c1d852970f162051fd1a7a6
iomap: Allow filesystem to call iomap_dio_complete without i_rwsem

This is to avoid the deadlock caused in btrfs because of O_DIRECT |
O_DSYNC.

Filesystems such as btrfs require i_rwsem while performing sync on a
file. iomap_dio_rw() is called under i_rw_sem. This leads to a
deadlock because of:

iomap_dio_complete()
  generic_write_sync()
    btrfs_sync_file()

Separate out iomap_dio_complete() from iomap_dio_rw(), so filesystems
can call iomap_dio_complete() after unlocking i_rwsem.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap/direct-io.c
include/linux/iomap.h