LoongArch: Put the body of play_dead() into arch_cpu_idle_dead()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Fri, 25 Aug 2023 15:40:38 +0000 (23:40 +0800)
committerHuacai Chen <chenhuacai@loongson.cn>
Fri, 25 Aug 2023 15:40:38 +0000 (23:40 +0800)
commitc337c849ab528241897ddfb6f334912ead0bfd66
tree5d6d2b56026b92f6bed77c30b0a2b810657560bc
parent8879515e1219857df1f142e23840b91a37cbde88
LoongArch: Put the body of play_dead() into arch_cpu_idle_dead()

The initial aim is to silence the following objtool warning:

arch/loongarch/kernel/process.o: warning: objtool: arch_cpu_idle_dead() falls through to next function start_thread()

According to tools/objtool/Documentation/objtool.txt, this is because
the last instruction of arch_cpu_idle_dead() is a call to a noreturn
function play_dead(). In order to silence the warning, one simple way
is to add the noreturn function play_dead() to objtool's hard-coded
global_noreturns array, that is to say, just put "NORETURN(play_dead)"
into tools/objtool/noreturns.h, it works well.

But I noticed that play_dead() is only defined once and only called by
arch_cpu_idle_dead(), so put the body of play_dead() into the caller
arch_cpu_idle_dead(), then remove the noreturn function play_dead() is
an alternative way which can reduce the overhead of the function call
at the same time.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
arch/loongarch/include/asm/smp.h
arch/loongarch/kernel/process.c
arch/loongarch/kernel/smp.c