USB: serial: ftdi_sio: simplify TIOCGSERIAL permission check
authorJohan Hovold <johan@kernel.org>
Wed, 7 Apr 2021 10:39:24 +0000 (12:39 +0200)
committerJohan Hovold <johan@kernel.org>
Thu, 8 Apr 2021 07:46:03 +0000 (09:46 +0200)
commitc12860c0f6e6b6b0301760a2b0e3e6b3f83eace8
treec3005d1fa404d7b918a9072883b936c7cfe9b2d3
parent9378379b15e3bab6915193874e1ac4464f36d869
USB: serial: ftdi_sio: simplify TIOCGSERIAL permission check

Changing the deprecated custom_divisor field is an unprivileged
operation so after verifying that flag field does not contain any
privileged changes both updates can be carried out by any user.

Combine the two branches and drop the erroneous comment.

Note that private flags field is only used for ASYNC flags so there's no
need to try to retain any other bits when updating the flags.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ftdi_sio.c