ACPI: scan: Rearrange memory allocation in acpi_device_add()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 14 Jan 2021 18:46:47 +0000 (19:46 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 25 Jan 2021 17:59:43 +0000 (18:59 +0100)
commitc1013ff7a5472db637c56bb6237f8343398c03a7
tree51c3ce7d1f1c0bc0e0586d19729373949ea58694
parent6ee1d745b7c9fd573fba142a2efdad76a9f1cb04
ACPI: scan: Rearrange memory allocation in acpi_device_add()

The upfront allocation of new_bus_id is done to avoid allocating
memory under acpi_device_lock, but it doesn't really help,
because (1) it leads to many unnecessary memory allocations for
_ADR devices, (2) kstrdup_const() is run under that lock anyway and
(3) it complicates the code.

Rearrange acpi_device_add() to allocate memory for a new struct
acpi_device_bus_id instance only when necessary, eliminate a redundant
local variable from it and reduce the number of labels in there.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
drivers/acpi/scan.c