drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()
authorMurray McAllister <murray.mcallister@gmail.com>
Sat, 11 May 2019 06:01:37 +0000 (18:01 +1200)
committerThomas Hellstrom <thellstrom@vmware.com>
Tue, 21 May 2019 08:23:10 +0000 (10:23 +0200)
commitbcd6aa7b6cbfd6f985f606c6f76046d782905820
tree697458d8b3f69a716cbbd0c7a14104b30f8082b1
parent8dc39cfca32c9a4e6deddaa0e76bd47d56f1876b
drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()

If SVGA_3D_CMD_DX_DEFINE_RENDERTARGET_VIEW is called with a surface
ID of SVGA3D_INVALID_ID, the srf struct will remain NULL after
vmw_cmd_res_check(), leading to a null pointer dereference in
vmw_view_add().

Cc: <stable@vger.kernel.org>
Fixes: d80efd5cb3de ("drm/vmwgfx: Initial DX support")
Signed-off-by: Murray McAllister <murray.mcallister@gmail.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c