PM: runtime: Do not call __rpm_callback() from rpm_idle()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 2 Dec 2022 14:30:28 +0000 (15:30 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 5 Dec 2022 14:43:37 +0000 (15:43 +0100)
commitbc80c2e438dcbfcf748452ec0f7ad5b79ff3ad88
tree7b1b05fdfbb1be71fc41b18d05855251b9f84bc9
parent76dcd734eca23168cb008912c0f69ff408905235
PM: runtime: Do not call __rpm_callback() from rpm_idle()

Calling __rpm_callback() from rpm_idle() after adding device links
support to the former is a clear mistake.

Not only it causes rpm_idle() to carry out unnecessary actions, but it
is also against the assumption regarding the stability of PM-runtime
status across __rpm_callback() invocations, because rpm_suspend() and
rpm_resume() may run in parallel with __rpm_callback() when it is called
by rpm_idle() and the device's PM-runtime status can be updated by any
of them.

Fixes: 21d5c57b3726 ("PM / runtime: Use device links")
Link: https://lore.kernel.org/linux-pm/36aed941-a73e-d937-2721-4f0decd61ce0@quicinc.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
drivers/base/power/runtime.c