fuse: Fix use-after-free in fuse_dev_do_read()
authorKirill Tkhai <ktkhai@virtuozzo.com>
Tue, 25 Sep 2018 09:28:55 +0000 (12:28 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Fri, 28 Sep 2018 14:43:21 +0000 (16:43 +0200)
commitbc78abbd55dd28e2287ec6d6502b842321a17c87
tree855aa7c8235688bb2ba0eed8ea56d942bea1c674
parent6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84
fuse: Fix use-after-free in fuse_dev_do_read()

We may pick freed req in this way:

[cpu0]                                  [cpu1]
fuse_dev_do_read()                      fuse_dev_do_write()
   list_move_tail(&req->list, ...);     ...
   spin_unlock(&fpq->lock);             ...
   ...                                  request_end(fc, req);
   ...                                    fuse_put_request(fc, req);
   if (test_bit(FR_INTERRUPTED, ...))
         queue_interrupt(fiq, req);

Fix that by keeping req alive until we finish all manipulations.

Reported-by: syzbot+4e975615ca01f2277bdd@syzkaller.appspotmail.com
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 46c34a348b0a ("fuse: no fc->lock for pqueue parts")
Cc: <stable@vger.kernel.org> # v4.2
fs/fuse/dev.c