drm/i915: Hold onto an explicit ref to i915_vma_work.pinned
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 2 Nov 2020 16:19:31 +0000 (16:19 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 3 Nov 2020 14:29:10 +0000 (14:29 +0000)
commitbc73e5d33048b7ab5f12b11b5d923700467a8e1d
treebd7e315b3d4e2aa5fbade0b76669d29428a8231f
parent09212e81e5450743e5b06b27c4e344e4c45b630d
drm/i915: Hold onto an explicit ref to i915_vma_work.pinned

Since __vma_release is run by a kworker after the fence has been
signaled, it is no longer protected by the active reference on the vma,
and so the alias of vw->pinned to vma->obj is also not protected by a
reference on the object. Add an explicit reference for vw->pinned so it
will always be safe.

Found by inspection.

Fixes: 54d7195f8c64 ("drm/i915: Unpin vma->obj on early error")
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201102161931.30031-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_vma.c