Revert "netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY"
authorFlorian Westphal <fw@strlen.de>
Wed, 16 Feb 2022 19:22:26 +0000 (20:22 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 3 Mar 2022 12:35:22 +0000 (13:35 +0100)
commitbbfbf7a5e77e4c899982c7df4cf3197cb6f99be4
tree53ae2fb40e8731dca179faf0829f7ef4c380da2f
parentef132dc40a28e07ba10b707b505781ffca46b97f
Revert "netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY"

This reverts commit 5bed9f3f63f8f9d2b1758c24640cbf77b5377511.

Gal Presman says:
 this patch broke geneve tunnels, or possibly all udp tunnels?
 A simple test that creates two geneve tunnels and runs tcp iperf fails
 and results in checksum errors (TcpInCsumErrors).

Original commit wanted to fix nf_reject with zero checksum,
so it appears better to change nf reject infra instead.

Fixes: 5bed9f3f63f8f ("netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY")
Reported-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_proto_udp.c