sched/core: Remove unlikely() annotation from sched_move_task()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 6 Feb 2017 16:04:26 +0000 (11:04 -0500)
committerIngo Molnar <mingo@kernel.org>
Fri, 10 Feb 2017 08:05:42 +0000 (09:05 +0100)
commitbb3bac2ca9a3a5b7fa601781adf70167a0449d75
tree9484f2817c8556b07e27bcac45eb53549fed8a2f
parent1051408f7ecdcd1baf86f5dd5fdc44740be3b23d
sched/core: Remove unlikely() annotation from sched_move_task()

The check for 'running' in sched_move_task() has an unlikely() around it. That
is, it is unlikely that the task being moved is running. That use to be
true. But with a couple of recent updates, it is now likely that the task
will be running.

The first change came from ea86cb4b7621 ("sched/cgroup: Fix
cpu_cgroup_fork() handling") that moved around the use case of
sched_move_task() in do_fork() where the call is now done after the task is
woken (hence it is running).

The second change came from 8e5bfa8c1f84 ("sched/autogroup: Do not use
autogroup->tg in zombie threads") where sched_move_task() is called by the
exit path, by the task that is exiting. Hence it too is running.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Link: http://lkml.kernel.org/r/20170206110426.27ca6426@gandalf.local.home
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c