scsi: efct: Fix possible memleak in efct_device_init()
authorChen Zhongjin <chenzhongjin@huawei.com>
Fri, 11 Nov 2022 07:40:46 +0000 (15:40 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Nov 2022 23:50:35 +0000 (23:50 +0000)
commitbb0cd225dd37df1f4a22e36dad59ff33178ecdfc
tree58e2dee3c417e73b271f7b8715a2bf84f8530d3f
parent222d227f375b4cfa517a8f1f0f266ebe0263ad05
scsi: efct: Fix possible memleak in efct_device_init()

In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
efct_scsi_tgt_driver_exit() is not called to release memory for
efct_scsi_tgt_driver_init() and causes memleak:

unreferenced object 0xffff8881020ce000 (size 2048):
  comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
  backtrace:
    [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
    [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
    [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
    [<00000000115de533>] 0xffffffffc0d90011
    [<00000000d608f646>] do_one_initcall+0xd0/0x4e0
    [<0000000067828cf1>] do_init_module+0x1cc/0x6a0
    ...

Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Link: https://lore.kernel.org/r/20221111074046.57061-1-chenzhongjin@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_driver.c