ext4: cleanup in-core orphan list if ext4_truncate() failed to get a transaction...
authorZhang Yi <yi.zhang@huawei.com>
Fri, 7 May 2021 07:19:04 +0000 (15:19 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 17 Jun 2021 14:53:19 +0000 (10:53 -0400)
commitb9a037b7f3c401d3c63e0423e56aef606b1ffaaf
treeb1280529a1506c7c80f61694582581708d9e3bfb
parentce3aba43599f0b50adbebff133df8d08a3d5fffe
ext4: cleanup in-core orphan list if ext4_truncate() failed to get a transaction handle

In ext4_orphan_cleanup(), if ext4_truncate() failed to get a transaction
handle, it didn't remove the inode from the in-core orphan list, which
may probably trigger below error dump in ext4_destroy_inode() during the
final iput() and could lead to memory corruption on the later orphan
list changes.

 EXT4-fs (sda): Inode 6291467 (00000000b8247c67): orphan list check failed!
 00000000b8247c670001f30a 00000004 00000000 00000023  ............#...
 00000000e24cde7100000006 014082a3 00000000 00000000  ......@.........
 0000000072c6a5ee00000000 00000000 00000000 00000000  ................
 ...

This patch fix this by cleanup in-core orphan list manually if
ext4_truncate() return error.

Cc: stable@kernel.org
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210507071904.160808-1-yi.zhang@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c