mptcp: update rtx timeout only if required.
authorPaolo Abeni <pabeni@redhat.com>
Wed, 18 Nov 2020 22:05:34 +0000 (23:05 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 Nov 2020 05:54:24 +0000 (21:54 -0800)
commitb680a214ec281dbd44b5ebbf3f126a57f1ecf0f7
tree8bbd114bccb17adb18a9fc0e08beb29af36c7827
parentac75b09624ed679e239b75081923a6d33ae35876
mptcp: update rtx timeout only if required.

We must start the retransmission timer only there are
pending data in the rtx queue.
Otherwise we can hit a WARN_ON in mptcp_reset_timer(),
as syzbot demonstrated.

Reported-and-tested-by: syzbot+42aa53dafb66a07e5a24@syzkaller.appspotmail.com
Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Link: https://lore.kernel.org/r/1a72039f112cae048c44d398ffa14e0a1432db3d.1605737083.git.pabeni@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c