KVM: SVM: Disable preemption across AVIC load/put during APICv refresh
authorSean Christopherson <seanjc@google.com>
Tue, 1 Mar 2022 17:05:09 +0000 (09:05 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 1 Mar 2022 17:21:23 +0000 (12:21 -0500)
commitb652de1e3dfb3b49e539e88a684a68e333e1bd7c
treeae1afcfc756c1caea6d1d07a30b5618cdaab8aa7
parentaa9f58415a8e45598bf44befa90b9d5babe09601
KVM: SVM: Disable preemption across AVIC load/put during APICv refresh

Disable preemption when loading/putting the AVIC during an APICv refresh.
If the vCPU task is preempted and migrated ot a different pCPU, the
unprotected avic_vcpu_load() could set the wrong pCPU in the physical ID
cache/table.

Pull the necessary code out of avic_vcpu_{,un}blocking() and into a new
helper to reduce the probability of introducing this exact bug a third
time.

Fixes: df7e4827c549 ("KVM: SVM: call avic_vcpu_load/avic_vcpu_put when enabling/disabling AVIC")
Cc: stable@vger.kernel.org
Reported-by: Maxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/svm/avic.c
arch/x86/kvm/svm/svm.c
arch/x86/kvm/svm/svm.h