firmware: arm_scmi: prevent accessing rate_discrete uninitialized
authorAnders Roxell <anders.roxell@linaro.org>
Fri, 16 Mar 2018 11:44:42 +0000 (12:44 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Tue, 20 Mar 2018 12:20:27 +0000 (12:20 +0000)
commitb5e817dcdd556da2b74c66af1cf0f44840283102
treee159278520aa0a7f088efcfaa13d5706fe255f9e
parentc09880cef78d0ddf149cdfeb733027a806465ba2
firmware: arm_scmi: prevent accessing rate_discrete uninitialized

gcc-5.3 and earlier warns that rate_discrete maybe-uninitialized
    ../drivers/firmware/arm_scmi/clock.c:185:5: warning: 'rate_discrete'
        may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (rate_discrete)
         ^
    ../drivers/firmware/arm_scmi/clock.c:128:7: note:
        'rate_discrete' was declared here
      bool rate_discrete;
           ^
This patch fixing the warning by initialising rate_discrete and also using
goto label for the error path.

Fixes: 5f6c6430e904 ("firmware: arm_scmi: add initial support for clock protocol")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
[sudeep.holla: added one line description to the commit message]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/clock.c