net: fec: remove eee_enabled/eee_active in fec_enet_get_eee()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 4 Feb 2024 12:13:12 +0000 (12:13 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 7 Feb 2024 17:03:37 +0000 (09:03 -0800)
commitb573cb0a55866830586eb26ce53e1163c1580667
treebc7b418ac53d031fc26ab0fdff237bce64294347
parentd0d8c548789d45391c7c592fb763fab2fee0f632
net: fec: remove eee_enabled/eee_active in fec_enet_get_eee()

fec_enet_get_eee() sets edata->eee_active and edata->eee_enabled from
its own copy, and then calls phy_ethtool_get_eee() which in turn will
call genphy_c45_ethtool_get_eee().

genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active
with its own interpretation from the PHYs settings and negotiation
result.

Therefore, setting these members in fec_enet_get_eee() is redundant.
Remove this, and remove the setting of fep->eee.eee_active member which
becomes a write-only variable.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1rWbN2-002cCh-MY@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c