posix-cpu-timers: Clear TICK_DEP_BIT_POSIX_TIMER on clone
authorBenjamin Segall <bsegall@google.com>
Sat, 26 Oct 2024 01:35:35 +0000 (18:35 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 27 Oct 2024 09:36:04 +0000 (10:36 +0100)
commitb5413156bad91dc2995a5c4eab1b05e56914638a
tree9da21dec930a7921db7e2a35e549d68cb98fba4f
parent42f7652d3eb527d03665b09edac47f85fb600924
posix-cpu-timers: Clear TICK_DEP_BIT_POSIX_TIMER on clone

When cloning a new thread, its posix_cputimers are not inherited, and
are cleared by posix_cputimers_init(). However, this does not clear the
tick dependency it creates in tsk->tick_dep_mask, and the handler does
not reach the code to clear the dependency if there were no timers to
begin with.

Thus if a thread has a cputimer running before clone/fork, all
descendants will prevent nohz_full unless they create a cputimer of
their own.

Fix this by entirely clearing the tick_dep_mask in copy_process().
(There is currently no inherited state that needs a tick dependency)

Process-wide timers do not have this problem because fork does not copy
signal_struct as a baseline, it creates one from scratch.

Fixes: b78783000d5c ("posix-cpu-timers: Migrate to use new tick dependency mask model")
Signed-off-by: Ben Segall <bsegall@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/xm26o737bq8o.fsf@google.com
include/linux/tick.h
kernel/fork.c