net: txgbe: fix memory leak in txgbe_probe() error path
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Tue, 15 Apr 2025 03:29:09 +0000 (08:59 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:12:36 +0000 (18:12 -0700)
commitb2727326d0a53709380aa147018085d71a6d4843
tree920f748d2f7510a09637c7a3520b2191dc637c6a
parenteb25de13bd9cf025413a04f25e715d0e99847e30
net: txgbe: fix memory leak in txgbe_probe() error path

When txgbe_sw_init() is called, memory is allocated for wx->rss_key
in wx_init_rss_key(). However, in txgbe_probe() function, the subsequent
error paths after txgbe_sw_init() don't free the rss_key. Fix that by
freeing it in error path along with wx->mac_table.

Also change the label to which execution jumps when txgbe_sw_init()
fails, because otherwise, it could lead to a double free for rss_key,
when the mac_table allocation fails in wx_sw_init().

Fixes: 937d46ecc5f9 ("net: wangxun: add ethtool_ops for channel number")
Reported-by: Jiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250415032910.13139-1-abdun.nihaal@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/txgbe/txgbe_main.c